Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "rosewater" for the jump label color in catppuccin themes #9983

Merged

Conversation

mandx
Copy link
Contributor

@mandx mandx commented Mar 24, 2024

Preview of catppuccin_mocha displaying helix-term/src/main.rs:

image

pascalkuthe
pascalkuthe previously approved these changes Mar 24, 2024
@the-mikedavis
Copy link
Member

Looks like this conflicts with #9980

@archseer
Copy link
Member

This version looks better, can you rebase and we'll merge? Also, this should probably be propagated to the upstream catppucin repository

@mandx mandx force-pushed the catppuccin-themes-jump-label-color branch from 1aa12d2 to 0f66d2b Compare March 24, 2024 03:17
@mandx mandx changed the title Add jump label color to catppuccin themes Use "rosewater" for the jump label color in catppuccin themes Mar 24, 2024
@mandx
Copy link
Contributor Author

mandx commented Mar 24, 2024

Rebased and changed the PR title

@mandx
Copy link
Contributor Author

mandx commented Mar 24, 2024

@archseer I added a PR in the upstream catppuccin repo catppuccin/helix#38

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 24, 2024
@archseer archseer merged commit 47995bf into helix-editor:master Mar 24, 2024
6 checks passed
@mandx mandx deleted the catppuccin-themes-jump-label-color branch March 24, 2024 16:18
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants